[compiler-v2] Add loop labels to the language #14868
Open
+461
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 50m total CI duration on this PR
|
15 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
15 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14868 +/- ##
========================================
Coverage 60.0% 60.0%
========================================
Files 856 856
Lines 210624 210737 +113
========================================
+ Hits 126573 126644 +71
- Misses 84051 84093 +42 ☔ View full report in Codecov by Sentry. |
vineethk
reviewed
Oct 6, 2024
| @@ -505,6 +507,10 @@ fn find_token( | |||
| (get_name_token(&text[..len]), len) | |||
| } | |||
| }, | |||
| '\'' => { | |||
| let len = get_name_len(&text[1..]); | |||
There was a problem hiding this comment.
I think we need some checks on the name, because the following code is currently allowed:
': loop {
break ';
};
'1: loop {
break '1;
};
'00x: loop {
break '00x;
};
We should ideally limit it to whatever our identifier rules are, which I think is what Rust does.
There was a problem hiding this comment.
@wrwg Just checking if this comment was missed.
wrwg
force-pushed
the
wrwg/astifier
branch
3 times, most recently
from
4352c47
to
ae2049a
Compare
Besides the user being able to describe more complex algorithms more efficiently, loop labels are required to express any reducible control flow in the AST language, and create parity of the AST with the bytecode level for this kind of code (which is also what can be generated from Move).
vineethk
approved these changes
Oct 9, 2024
| @@ -505,6 +507,10 @@ fn find_token( | |||
| (get_name_token(&text[..len]), len) | |||
| } | |||
| }, | |||
| '\'' => { | |||
| let len = get_name_len(&text[1..]); | |||
There was a problem hiding this comment.
@wrwg Just checking if this comment was missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Besides the user being able to describe complex algorithms more efficiently, loop labels are required to express aribtrary reducible control flow graphs in the AST language, and create parity of the AST with the bytecode level for this kind of code (which is also what can be generated from Move).
How Has This Been Tested?
New baseline tests in checking, v1-checking, bytecode generation, and a transactional test.
Type of Change
Which Components or Systems Does This Change Impact?